On Wed, Oct 16, 2019 at 9:55 AM Daniel Shahaf <d...@daniel.shahaf.name> wrote: > > Yasuhito FUTATSUKI wrote on Wed, 16 Oct 2019 04:40 +00:00: > > On 2019/10/16 10:36, Daniel Shahaf wrote: > > > Yasuhito FUTATSUKI wrote on Tue, Oct 15, 2019 at 16:19:46 +0900: > > >> On 2019-10-15 07:04, Daniel Shahaf wrote: > > >>> Yasuhito FUTATSUKI wrote on Sun, 13 Oct 2019 04:01 +00:00: > > >>>> On 2019/10/13 7:24, Daniel Shahaf wrote: > > > > >>> Also, what about the svnadmin_tests.py patch you posted upthread? Is > > >>> there a reason not to go ahead and commit it to trunk? (and even > > >>> nominate > > >>> it for backport in 1.13.x/STATUS) > > >> > > >> I think that is no probrem. > > > > > > Let me elaborate. By my reckoning, «make check» on trunk has a false > > > positive > > > when ${PYTHON} is python3; and furthermore, python2 will reach EOL during > > > the > > > lifetime of the 1.13 branch; therefore, we should fix the false positive > > > and > > > backport the fix to supported branches. What's your view? > > > > I agree with you, because I think we should publish at least one relase > > support Python 3, so that we can remove the sentence "Note that Python 3.x > > is not supported and most likely won't work." in "Dependencies in Detail" > > section of INSTALL file, before EOL of Python 2. > > Good catch. Yes, we should update INSTALL to reflect that Python 3 is > supported for the build and test process, even if it's not yet supported > by the swig bindings in trunk and 1.13.x. Would you be able to update > that? You're welcome to just commit changes to trunk/INSTALL directly, > if that's easier for you.
Python 3 for the build and test process is only supported on *nix, not on Windows. [[[ Traceback (most recent call last): File "win-tests.py", line 134, in <module> cp.items('options')) File "build\generator\gen_win_dependencies.py", line 306, in __init__ self.find_libraries(False) File "build\generator\gen_win_dependencies.py", line 327, in find_libraries self._find_jdk(show_warnings) File "build\generator\gen_win_dependencies.py", line 1085, in _find_jdk vermatch = re.search(r'(([0-9]+(\.[0-9]+)+)(_[._0-9]+)?)', line, re.M) File "C:\Python37\lib\re.py", line 183, in search return _compile(pattern, flags).search(string) TypeError: cannot use a string pattern on a bytes-like object ]]] The fix is probably easy, but I'm just noting it here so we don't get ahead of ourselves. -- Johan