I agree on having an rc2. Let's cherry-pick this commit (and any other safe bug fixes that have come in since) and cut a new rc.
-1 Erik On Fri, Apr 2, 2021 at 4:39 PM Beto Dealmeida <robe...@dealmeida.net.invalid> wrote: > I think we should cherry-pick the fix and do an RC2, it's a 1-character > fix and personally I use that feature all the time. > > On 4/2/21 4:13 PM, Evan Rusackas wrote: > > This issue was addressed after the RC was cut, by this PR: > > https://github.com/apache/superset/pull/13657 > > > > There is a workaround available of copying the query and pasting it into > SQL Lab manually. > > > > Since I’m not sure how many people rely on that feature, I’m not sure if > this constitutes a bug worthy of RC2 or not. Thoughts, anyone? > > > > Thanks, > > > > -e- > > > > Evan Rusackas > > Preset | preset.io > > On Apr 2, 2021, 4:10 PM -0700, Junlin Chen <jun...@preset.io>, wrote: > >> Identified an issue during testing of 1.1/1.1.0 branches. > >> When clicking on 'Run in SQL Lab' from Explore in any > >> chart, flask.debughelpers.FormDataRoutingRedirect is returned and the > whole > >> page crashed. > >> although there's a workaround, this button is quite commonly used... > *I'm > >> inclined to have rc2. * > >> *thanks for testing *@Evan Rusackas <e...@preset.io>* and validating > *@Phillip > >> Kelley-Dotson <phil...@preset.io> > >> > >> On Tue, Mar 30, 2021 at 5:59 PM Srinivasa Kadamati <sr...@preset.io> > wrote: > >> > >>> Oh today I learned! Cool yeah we can add this for future releases / in > the > >>> template :) > >>> > >>> On Tue, Mar 30, 2021 at 8:52 PM Beto Dealmeida > >>> <robe...@dealmeida.net.invalid> wrote: > >>> > >>>> Thanks! > >>>> > >>>> (The email calling for the vote is autogenerated, and I think it might > >>>> be non-trivial to add the link to the release notes programmatically.) > >>>> > >>>> > >>>> On 3/30/21 5:04 PM, Srinivasa Kadamati wrote: > >>>>> We should also include the Release Notes > >>>>> > >>>>> > >>> > https://github.com/apache/superset/tree/1.1.0rc1/RELEASING/release-notes-1-1 > >>>>> > >>>>> On Tue, Mar 30, 2021 at 5:25 PM <b...@apache.org> wrote: > >>>>> > >>>>>> Hello Superset Community, > >>>>>> > >>>>>> This is a call for the vote to release Apache Superset version > 1.1.0. > >>>>>> > >>>>>> The release candidate: > >>>>>> https://dist.apache.org/repos/dist/dev/superset/1.1.0rc1/ > >>>>>> > >>>>>> Git tag for the release: > >>>>>> https://github.com/apache/superset/tree/1.1.0rc1 > >>>>>> > >>>>>> The Change Log for the release: > >>>>>> https://github.com/apache/superset/blob/1.1.0rc1/CHANGELOG.md > >>>>>> > >>>>>> The Updating instructions for the release: > >>>>>> https://github.com/apache/superset/blob/1.1.0rc1/UPDATING.md > >>>>>> > >>>>>> public keys are available at: > >>>>>> > >>>>>> https://www.apache.org/dist/superset/KEYS > >>>>>> > >>>>>> The vote will be open for at least 72 hours or until the necessary > >>>> number > >>>>>> of votes are reached. > >>>>>> > >>>>>> Please vote accordingly: > >>>>>> > >>>>>> [ ] +1 approve > >>>>>> [ ] +0 no opinion > >>>>>> [ ] -1 disapprove with the reason > >>>>>> > >>>>>> Thanks, > >>>>>> The Apache Superset Team > >>>>>> >
