+1 binding On Mon, Feb 14, 2022 at 6:33 PM Srinivasa Kadamati <sr...@preset.io> wrote:
> +1 (binding) > > This is super exciting! > > On Mon, Feb 14, 2022 at 8:47 PM John Bodley <john.bod...@airbnb.com > .invalid> > wrote: > > > +1 (binding) > > > > Thanks Aaron for coordinating this. > > > > On Tue, Feb 15, 2022 at 2:07 PM Elizabeth Thompson <elizab...@preset.io> > > wrote: > > > > > +1 Binding > > > > > > > On Feb 14, 2022, at 5:02 PM, Aaron Suddjian <aa...@preset.io> wrote: > > > > > > > > In the process of checking the list, I noticed that "Turn on > > > > SQLLAB_BACKEND_PERSISTENCE by default" ended up in the wrong column, > > and > > > > should be considered for inclusion. That's not removal of the feature > > > flag, > > > > just changing its default value. > > > > > > > > Thanks all, I think we can continue the vote unless there are further > > > > comments/concerns 😁 > > > > > > > > On Mon, Feb 14, 2022 at 4:36 PM Aaron Suddjian <aa...@preset.io> > > wrote: > > > > > > > >> Thanks for pointing that out Beto! > > > >> > > > >> The VERSIONED_EXPORT item should be thought of as permanently > turning > > > the > > > >> flag on, removing the flag. This is desirable in cases where having > > the > > > >> flag on has become the clearly superior experience, and where > > > maintaining > > > >> multiple options sustains an undue amount of tech debt. Some other > > > flags in > > > >> the list got the same treatment. > > > >> > > > >> Some of us had a meeting to quickly go through the list of proposals > > > since > > > >> there hadn't been much movement in the past months. We decided that > it > > > >> would be good to focus primarily on CLI and config changes. I'll > post > > > >> explanations for the ones considered unsuitable on the SIP. > > > >> > > > >> On Mon, Feb 14, 2022 at 3:41 PM Beto Dealmeida > > > >> <robe...@dealmeida.net.invalid> wrote: > > > >> > > > >>> I have a comment on one item: > > > >>> > > > >>> # Remove old import/export code and turn on the VERSIONED_EXPORT > flag > > > by > > > >>> default. > > > >>> > > > >>> We can't remove the old code and have the feature flag at the same > > > time; > > > >>> the old code is needed to turn the feature flag off. > > > >>> > > > >>> It also seems that many features were considered unsuitable > without a > > > >>> comment explaining why. > > > >>> > > > >>> On 2/14/22 3:34 PM, Aaron Suddjian wrote: > > > >>>> Hi all, > > > >>>> > > > >>>> I'd like to call for a vote on SIP-74, Superset 2.0 Breaking > > Changes: > > > >>>> https://github.com/apache/superset/issues/17081 > > > >>>> > > > >>>> The vote will be open for at least 1 week or until the necessary > > > number > > > >>> of > > > >>>> votes are reached. > > > >>>> > > > >>>> Please vote accordingly: > > > >>>> [ ] +1 approve > > > >>>> [ ] +0 no opinion > > > >>>> [ ] -1 disapprove with the reason > > > >>>> > > > >>>> Thank you all for your discussion and collaboration around this > > > >>> proposal. > > > >>>> > > > >>> > > > >> > > > >> > > > >> -- > > > >> Aaron Suddjian, Software Engineer at Preset > > > >> > > > > > > > > > > > > -- > > > > Aaron Suddjian, Software Engineer at Preset > > > > > > > > > -- -Tai Dupree
