+1 approve On Tue, Nov 28, 2023 at 12:44 PM John Bodley <john.bod...@airbnb.com.invalid> wrote:
> Hi, > > Having launched a formal discussion thread for [SIP-99] Proposal for > correctly handling business logic > <https://github.com/apache/superset/issues/25048> a few weeks ago [1], and > having not received any major feedback, I thought it would be prudent to > now put the SIP to a vote. > > As a reminder the SIP covers a slew of subtopics which are broken down into > sub-SIPs, i.e., SIP-99 merely serves as an umbrella, whereas > > - [SIP-99A] Primer on managing SQLAlchemy sessions > <https://github.com/apache/superset/issues/25107> > > is merely a primer (to help set context), and > > - [SIP-99B] Proposal for (re)defining a “unit of work” > <https://github.com/apache/superset/issues/25108> > - [SIP-99C] Proposal for model and business validation > <https://github.com/apache/superset/issues/25828> > - [SIP-99D] Proposal for consolidating Command/DAO create, update, and > upsert operations <https://github.com/apache/superset/issues/25830> > > outline the actual proposed changes. > > The vote will be open for at least 72 hours or until the necessary number > of votes are reached. Please vote accordingly: > > [ ] +1 approve > [ ] +0 no opinion > [ ] -1 disapprove with the reason > > If this warrants further discussion, we can leave the vote open longer to > accommodate. > > Thanks > -John > > [1] https://lists.apache.org/thread/5y42olok00xtdbpw8pzq4hbrlmr57p79 >
