williaster commented on a change in pull request #3581: Dashboard refactory
URL:
https://github.com/apache/incubator-superset/pull/3581#discussion_r147904056
##########
File path: superset/assets/javascripts/dashboard/components/Controls.jsx
##########
@@ -36,11 +45,11 @@ class Controls extends React.PureComponent {
}
refresh() {
// Force refresh all slices
- this.props.dashboard.renderSlices(this.props.dashboard.sliceObjects, true);
+ this.props.renderSlices(true);
}
changeCss(css) {
this.setState({ css });
- this.props.dashboard.onChange();
+ this.props.onChange();
}
render() {
const dashboard = this.props.dashboard;
Review comment:
you could destructure all of the variables used in the calls to
`this.props.xxx` below to simplify.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
