williaster commented on a change in pull request #3581: Dashboard refactory
URL:
https://github.com/apache/incubator-superset/pull/3581#discussion_r147901597
##########
File path: superset/assets/javascripts/chart/ChartBody.jsx
##########
@@ -0,0 +1,54 @@
+import React from 'react';
+import PropTypes from 'prop-types';
+import $ from 'jquery';
+
+const propTypes = {
+ containerId: PropTypes.string,
+ vizType: PropTypes.string,
+ height: PropTypes.func,
Review comment:
I'd make these required or add defaults, if they're not passed now your
`this.props.width` etc calls below would throw
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
