john-bodley commented on issue #4669: [sqllab] Using app context for processing Jinja template in async mode URL: https://github.com/apache/incubator-superset/pull/4669#issuecomment-376238469 @mistercrunch even though in `sql_lab.py` [get_sqla_engine](https://github.com/apache/incubator-superset/blob/master/superset/sql_lab.py#L209) is called with the `user_name` parameter, the Jinja template issue we're seeing is when one is using `presto.latest_partition` which doesn't pass through the username, and from reading through the code this may neither be feasible nor non-trivial. How do you feel about the change? Note I'm somewhat perplex how other portions of `execute_sql` work on a Celery worker like [get_session](https://github.com/apache/incubator-superset/blob/master/superset/sql_lab.py#L81) which references `app` as I presume that would also be working outside of an app context.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
