john-bodley commented on issue #4669: [sqllab] Using app context for processing 
Jinja template in async mode
URL: 
https://github.com/apache/incubator-superset/pull/4669#issuecomment-376704910
 
 
   @mistercrunch how does 
[this](https://github.com/apache/incubator-superset/blob/master/superset/sql_lab.py#L81)
 existing logic work , i.e., `get_session` is called by the Celery worker to 
get the db session, using the configuration logic defined in `app.config`, yet 
the app context shouldn't be defined. 
   
   Is there any reason we don't pass the `session` to the Celery task?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to