[
https://issues.apache.org/jira/browse/SYNCOPE-259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13543031#comment-13543031
]
Andrei Shakirin commented on SYNCOPE-259:
-----------------------------------------
Hi Francesco, thanks for fast feedback.
- (1) and (2) are just JAX-RS annotations, not really used at the moment - all
operations in proxy are working as before using old HTTP methods. Anyway, we
should think about it on the next step, when JAX-RS CXF will be used. GET HTTP
operation should be safe by definition, that is not the case for
resource.delete(). Perhaps combination get + delete will be better for this.
- check() has ResourceTO as argument, but actual implementation uses only
resourceTO.getConnectorId() from incoming argument. Perhaps we can just pass
connectorID directly to check() operation and move it to ConnInstanceService.
- getPropagationActionsClasses(): agree to leave it into ResourceService.
> Create transitional Service interfaces and switch tests and console to use
> them
> -------------------------------------------------------------------------------
>
> Key: SYNCOPE-259
> URL: https://issues.apache.org/jira/browse/SYNCOPE-259
> Project: Syncope
> Issue Type: Improvement
> Components: client, console, core
> Affects Versions: 1.1.0
> Reporter: Christian Schneider
> Assignee: Jan Bernhardt
> Fix For: 1.1.0
>
> Attachments: ResourceService.patch, SYNCOPE-259.patch
>
>
> As preparation of the change to use CXF instead of Spring MVC REST
> controllers this issue is to introduce transitional service interfaces (like
> as UserService).
> The UserService interface should later be used in the core to provide the
> UserController and on the console to access the service remotely.
> To make the transition easier the idea is to already introduce the interface
> upfront and change all tests and the console to use it. Before the switch the
> implementation of the interface will simply use the restTemplate under the
> covers.
> This to be applied similarly to all Spring MVC REST controllers.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
