[
https://issues.apache.org/jira/browse/SYNCOPE-259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13543745#comment-13543745
]
Jan Bernhardt commented on SYNCOPE-259:
---------------------------------------
Hi Andrei, thanks for your patch! Looks very good in general.
Could you please also document the REST API changes for your patch here:
https://cwiki.apache.org/confluence/display/SYNCOPE/REST+API+upgrade
@Francesco Could you please provide read/write access to: ashakirin
Here are a couple of (minor) thinks that I have changed:
Inside Service Interface:
1. Applied your previous comment and removed "public" as it is redundant in
interface declarations
2. Removed leading slash "/" in @Path annotations, as it is also redundant (see
JavaDoc samples: http://docs.oracle.com/javaee/6/api/javax/ws/rs/Path.html)
2.1 Removed @Path("/") annotations as they are also redundant
3. renamed @Path("/resource") interface path to @Path("resources"), as service
paths should be in plural (according to best practices)
4. renamed @Path("check") to @Path("validate")
Inside Proxy:
1. Instead of suppressing a warning, I changed the
getPropagationActionsClasses() method to use Array -> List -> Set mappings
> Create transitional Service interfaces and switch tests and console to use
> them
> -------------------------------------------------------------------------------
>
> Key: SYNCOPE-259
> URL: https://issues.apache.org/jira/browse/SYNCOPE-259
> Project: Syncope
> Issue Type: Improvement
> Components: client, console, core
> Affects Versions: 1.1.0
> Reporter: Christian Schneider
> Assignee: Jan Bernhardt
> Fix For: 1.1.0
>
> Attachments: ResourceService-1428511.patch, ResourceService.patch,
> SYNCOPE-259.patch
>
>
> As preparation of the change to use CXF instead of Spring MVC REST
> controllers this issue is to introduce transitional service interfaces (like
> as UserService).
> The UserService interface should later be used in the core to provide the
> UserController and on the console to access the service remotely.
> To make the transition easier the idea is to already introduce the interface
> upfront and change all tests and the console to use it. Before the switch the
> implementation of the interface will simply use the restTemplate under the
> covers.
> This to be applied similarly to all Spring MVC REST controllers.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
