On 02/02/2013 10:10, Andrei Shakirin wrote:
Hi,
Analyses shows, that real reason of failed/unstable tests is not AUTO
generation strategy itself as reported in [1], but collision between newly
created and pre-configured entries.
Actually following entities have AUTO generation strategy:
- AbstractDerAttr
- AbstractVirAttr
- Notification
- UserRequest
- UAttr
I propose tree possible ways to fix the problem:
A) Increase Id of corresponded pre-configured entities to large number (>1000)
to make collision non probable.
B) Avoid pre-configured objects for all entities with AUTO generation strategy.
Redesign tests to create necessary data on the fly
C) Change AUTO generation strategy to TABLE one.
(A) is easiest, but looks like workaround for me. (B) sounds as the most
reasonable. (C) is possible, but requires change in persistence strategy just
because of tests (not the best practice)
Hi Andrei,
first of all, thanks for caring about this!
I agree with you that (A) is easy and sounds like a workaround but...
we're talking about test data, hence workarounds don't smell like as
usual :-)
IMO, relying upon some default test data is actually very comfortable,
so I wouldn't opt for (B).
I agree with you about (C) : would this mean that SYNCOPE-298 could be
marked as invalid at the end of the current discussion?
Regards.
[1] https://issues.apache.org/jira/browse/SYNCOPE-298
--
Francesco Chicchiriccò
ASF Member, Apache Syncope PMC chair, Apache Cocoon PMC Member
http://people.apache.org/~ilgrosso/
