Hi Francesco,

> -----Original Message-----
> From: Francesco Chicchiriccò [mailto:ilgro...@apache.org]
> Sent: Dienstag, 5. Februar 2013 11:38
> To: dev@syncope.apache.org
> Subject: "dbDump" in ReportService and ConfigurationService
> 
> Hi all,
> I am currently completing some modifications started yesterday with
> ConfigurationServiceProxy.dbExport() that will involve some refactoring on
> console's HttpResourceStream and also to core's ReportTestITCase.
> 
> Basically, I would like to encapsulate the logic for handling streams
> (content.xml and reports in various formats) in the relevant service proxies.
> 
> While doing this, I've just noticed that ReportSevice has
> 
>      @GET
>      @Path("executions/{executionId}/dbDump")
>      Response exportExecutionResult(@PathParam("executionId") Long
> executionId,
>              @QueryParam("format") ReportExecExportFormat fmt);
> 
> while ConfigurationService has
> 
>      @GET
>      @Path("dbDump")
>      Response dbExport();
> 
> Any special reason for this "dbDump"?

No there is no special reason for "dbDump". (Code looks to me, as if this is 
what happens here.) I only tried to find a consistent manner, who to title a 
downloadable stream. I'm completely open for any suggestions/improvements for a 
different URL path.

Best regards.
Jan

> The only thing I can see is that both methods return an object stream (that
> can be in some cases XML) instead of serialized instances in JSON / XML as
> the rest.
> 
> Regards.
> 
> --
> Francesco Chicchiriccò
> 
> ASF Member, Apache Syncope PMC chair, Apache Cocoon PMC Member
> http://people.apache.org/~ilgrosso/

Reply via email to