+1 Best regards. Jan
> -----Original Message----- > From: Francesco Chicchiriccò [mailto:ilgro...@apache.org] > Sent: Donnerstag, 7. Februar 2013 10:36 > To: dev@syncope.apache.org > Subject: Re: "dbDump" in ReportService and ConfigurationService > > On 06/02/2013 12:08, Jan Bernhardt wrote: > > Hi Francesco, > >> From: Francesco Chicchiriccò [mailto:ilgro...@apache.org] > >> > >> Hi all, > >> I am currently completing some modifications started yesterday with > >> ConfigurationServiceProxy.dbExport() that will involve some > >> refactoring on console's HttpResourceStream and also to core's > ReportTestITCase. > >> > >> Basically, I would like to encapsulate the logic for handling streams > >> (content.xml and reports in various formats) in the relevant service > proxies. > >> > >> While doing this, I've just noticed that ReportSevice has > >> > >> @GET > >> @Path("executions/{executionId}/dbDump") > >> Response exportExecutionResult(@PathParam("executionId") Long > >> executionId, > >> @QueryParam("format") ReportExecExportFormat fmt); > >> > >> while ConfigurationService has > >> > >> @GET > >> @Path("dbDump") > >> Response dbExport(); > >> > >> Any special reason for this "dbDump"? > > No there is no special reason for "dbDump". (Code looks to me, as if this is > what happens here.) I only tried to find a consistent manner, who to title a > downloadable stream. I'm completely open for any > suggestions/improvements for a different URL path. > > > What about > > @GET > @Path("executions/{executionId}/stream") > Response exportExecutionResult(@PathParam("executionId") Long > executionId, > @QueryParam("format") ReportExecExportFormat fmt); > > and > > @GET > @Path("stream") > Response dbExport(); > > ? > > Regards. > > -- > Francesco Chicchiriccò > > ASF Member, Apache Syncope PMC chair, Apache Cocoon PMC Member > http://people.apache.org/~ilgrosso/
