github-advanced-security[bot] commented on code in PR #1127: URL: https://github.com/apache/syncope/pull/1127#discussion_r2184889278
########## ext/scimv2/logic/src/main/java/org/apache/syncope/core/logic/SCIMDataBinder.java: ########## @@ -1029,18 +1038,15 @@ long count = userLogic.search( searchCond, PageRequest.of(0, 1), SyncopeConstants.ROOT_REALM, true, false).getTotalElements(); - for (int page = 0; page <= (count / AnyDAO.DEFAULT_PAGE_SIZE); page++) { - List<UserTO> users = userLogic.search( - searchCond, - PageRequest.of(page, AnyDAO.DEFAULT_PAGE_SIZE), - SyncopeConstants.ROOT_REALM, - true, - false). - getContent(); - users.forEach(userTO -> group.getMembers().add(new Member( - userTO.getKey(), - StringUtils.substringBefore(location, "/Groups") + "/Users/" + userTO.getKey(), - userTO.getUsername()))); + for (int page = 0; page <= (count / AnyDAO.DEFAULT_PAGE_SIZE) + 1; page++) { Review Comment: ## Comparison of narrow type with wide type in loop condition Comparison between [expression](1) of type int and [expression](2) of wider type long. [Show more details](https://github.com/apache/syncope/security/code-scanning/2261) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@syncope.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org