ilgrosso commented on code in PR #1127:
URL: https://github.com/apache/syncope/pull/1127#discussion_r2184937096
##########
ext/scimv2/logic/src/main/java/org/apache/syncope/core/logic/SCIMDataBinder.java:
##########
@@ -1029,18 +1038,15 @@
long count = userLogic.search(
searchCond, PageRequest.of(0, 1),
SyncopeConstants.ROOT_REALM, true, false).getTotalElements();
- for (int page = 0; page <= (count / AnyDAO.DEFAULT_PAGE_SIZE);
page++) {
- List<UserTO> users = userLogic.search(
- searchCond,
- PageRequest.of(page, AnyDAO.DEFAULT_PAGE_SIZE),
- SyncopeConstants.ROOT_REALM,
- true,
- false).
- getContent();
- users.forEach(userTO -> group.getMembers().add(new Member(
- userTO.getKey(),
- StringUtils.substringBefore(location, "/Groups") +
"/Users/" + userTO.getKey(),
- userTO.getUsername())));
+ for (int page = 0; page <= (count / AnyDAO.DEFAULT_PAGE_SIZE) + 1;
page++) {
Review Comment:
@SamuelGaro sorry revert the last commit, I was looking at similar code in
other classes and it seems we chose to stay with the original warning, sorry
for the noise
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
