TMaddox commented on a change in pull request #1270:
URL: https://github.com/apache/systemds/pull/1270#discussion_r637580645
##########
File path: src/main/python/systemds/script_building/dag.py
##########
@@ -74,12 +74,13 @@ class DAGNode(ABC):
sds_context: 'SystemDSContext'
_unnamed_input_nodes: Sequence[Union['DAGNode', str, int, float, bool]]
_named_input_nodes: Dict[str, Union['DAGNode', str, int, float, bool]]
+ _named_output_nodes: Dict[str, Union['DAGNode', str, int, float, bool]]
Review comment:
Without this we won't be able to do something like this: `node2 =
node1["res"].abs()` or this `node3 = node2["X_train"] + node2["Y_train"]`? The
only possibility would be to get the output node by the index. (While at the
moment we can do both, by index (not included in this PR, but already
implemented) or by name). Or am I missing something?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
