well, this voting thread is not the place to discuss these things, but
if no -exec argument is specified the default is hybrid. Period. The
fact that the systemds "util" script forces it into singlenode if it's
about to run via plain java is fine, but does not change the overall
positioning of SystemDS.
Similarly, for backwards compatibility I would strongly recommend to
keep algorithms, datagen, etc folders as they are until they are
properly deprecated and subsequently removed.
Regards,
Matthias
On 6/23/2021 5:00 PM, Baunsgaard, Sebastian wrote:
Lines 43 to 46 in systemds/bin [1] specify the default when executing through
our bin files.
If $SYSDS_DISTRIBUTED is actively set to true, then hybrid mode, else single
node.
It might be that the default internally in java is hybrid.
Mark did change this in a commit, and i changed it back, after it introduced
bugs in some of our federated executions (we had a verbal discussion about this
at some point). Most of our federated tests and executions have been in
singlenode (because the /bin/systemds script use singlenode) therefore there
most likely is bugs when executing using hybrid.
[1]
https://github.com/apache/systemds/blob/4037b98ed0bf84ae61188f695c472246376fb445/bin/systemds#L42
________________________________
From: Matthias Boehm <[email protected]>
Sent: Wednesday, June 23, 2021 4:48:06 PM
To: [email protected]
Subject: Re: [VOTE] Apache SystemDS 2.1.0 (RC3)
just to clarify - the default is and will remain 'hybrid'.
Regards,
Matthias
On 6/23/2021 4:46 PM, Baunsgaard, Sebastian wrote:
+1,
but i would like to cleanup the following:
README bugs:
- line 82 says that our default execution is hybrid, while it is actually
single node
- The output is not equivalent to the lines 94 - 113, since running without any
environment much more is written to the terminal.
- line 77 use http not https.
- line 33 use http not https.
In general i would like to remove this README, or replace it with a link to
some of our live documentation, to enable updates without it being part of the
release.
I would remove the following folders from the release, since these don't have
any influence on execution but could be looked up in our repository:
- scripts/algorithms
- scripts/aws
- scripts/datagen
- scripts/pipelines
also some of the scripts in scripts/util could be removed, and in the builtin
we should remove our test scripts:
- scripts/builtin/xdummy1.dml
- scripts/builtin/xdummy2.dml
in NN i also think we should remove:
- scripts/nn/examples
Best regards
Sebastian
________________________________
From: arnab phani <[email protected]>
Sent: Wednesday, June 23, 2021 3:22:56 PM
To: [email protected]
Subject: Re: [VOTE] Apache SystemDS 2.1.0 (RC3)
+1
Looks good to me as well.
Regards,
Arnab..
On Tue, Jun 22, 2021 at 11:18 PM Matthias Boehm <[email protected]> wrote:
+1, this rc3 looks good to me - thanks to everybody for fixing the
remaining issues.
Regards,
Matthias
On 6/22/2021 9:11 PM, arnab phani wrote:
One correction.
The link to the release artifacts is wrong in the last email.
Here is the right link
https://dist.apache.org/repos/dist/dev/systemds/2.1.0-rc3/
I apologize for the inconvenience.
Regards,
Arnab..
On Tue, Jun 22, 2021 at 8:38 PM arnab phani <[email protected]>
wrote:
Please vote on releasing the following candidate as Apache
SystemDS version 2.1.0
The vote is open for at least 72 hours and passes if a majority of at
least 3 +1 PMC votes are cast.
[ ] +1 Release this package as Apache SystemDS 2.1.0
[ ] -1 Do not release this package because ...
To learn more about Apache SystemDS, please see
http://systemds.apache.org/
The tag to be voted on is v2.1.0-rc3
(ba9276fa1ee366e6acfe0df814253921549a97be):
https://github.com/apache/systemds/tree/2.1.0-rc3
The release artifacts can be found at:
https://dist.apache.org/repos/dist/dev/systemds/2.0.0-rc3/
The maven release artifacts, including signatures, digests, etc. can be
found at:
https://repository.apache.org/content/repositories/orgapachesystemds-1050/org/apache/systemds/systemds/2.1.0/
===========================
== Apache Release policy ==
===========================
http://www.apache.org/legal/release-policy.html
=======================================
== How can I help test this release? ==
=======================================
If you are a SystemDS user, you can help us test this release by taking
an
existing Algorithm or workload and running on this release candidate,
then
reporting any regressions.
================================================
== What justifies a -1 vote for this release? ==
================================================
-1 votes should only occur for significant stop-ship bugs or legal
related
issues (e.g. wrong license, missing header files, etc). Minor bugs or
regressions should not block this release.
Regards,
Arnab..
