Baunsgaard commented on code in PR #1617: URL: https://github.com/apache/systemds/pull/1617#discussion_r909246495
########## scripts/perftest/runAll.sh: ########## @@ -26,50 +26,94 @@ then exit 1; fi -# Optional argument that can be a folder name for where generated data is stored Review Comment: I don't understand your code reference, but i think i get your point. I disagree since the perftest ideally should be run as a self contained test suite on released artifacts. This currently is possible by changing folder from root, because our shell script for executing systemds defaults to use our src if you run it from somewhere that looks like the root of our project overwriting any specific use of artifacts. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
