BACtaki commented on code in PR #1677:
URL: https://github.com/apache/systemds/pull/1677#discussion_r1002845067
##########
src/main/java/org/apache/sysds/runtime/instructions/SPInstructionParser.java:
##########
@@ -126,7 +126,9 @@ public class SPInstructionParser extends InstructionParser
String2SPInstructionType.put( "uac*" ,
SPType.AggregateUnary);
String2SPInstructionType.put( "uatrace" ,
SPType.AggregateUnary);
String2SPInstructionType.put( "uaktrace",
SPType.AggregateUnary);
- String2SPInstructionType.put( "uacdap" ,
SPType.AggregateUnary);
+ String2SPInstructionType.put( "uacd" ,
SPType.AggregateUnary);
+ String2SPInstructionType.put( "uacdr" ,
SPType.AggregateUnary);
+ String2SPInstructionType.put( "uacdc" ,
SPType.AggregateUnary);
Review Comment:
They are already there- they are in a separate "section" for sketch
operators:
```
String2SPInstructionType.put( "uacd" ,
SPType.AggregateUnary);
String2SPInstructionType.put( "uacdr" ,
SPType.AggregateUnary);
String2SPInstructionType.put( "uacdc" ,
SPType.AggregateUnary);
// Aggregate unary sketch operators
String2SPInstructionType.put( "uacdap" ,
SPType.AggregateUnarySketch);
String2SPInstructionType.put( "uacdapr",
SPType.AggregateUnarySketch);
String2SPInstructionType.put( "uacdapc",
SPType.AggregateUnarySketch);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
