Baunsgaard opened a new pull request, #1755: URL: https://github.com/apache/systemds/pull/1755
This commit update the change of matrix to frame to more efficiently change the MatrixBlock to frames. The previous implementation has nice cache blocks and allocation for direct double to double change, this PR simply adds support for this change in the case of changing into other types, like boolean. Changing a Matrix 64kx2k to boolean frame: After: 22/12/21 19:56:11 ERROR frame.FrameFromMatrixBlockTest: 1055.994364 22/12/21 19:56:12 ERROR frame.FrameFromMatrixBlockTest: 1039.756463 22/12/21 19:56:13 ERROR frame.FrameFromMatrixBlockTest: 946.029085 22/12/21 19:56:14 ERROR frame.FrameFromMatrixBlockTest: 928.161053 22/12/21 19:56:15 ERROR frame.FrameFromMatrixBlockTest: 943.132151 22/12/21 19:56:16 ERROR frame.FrameFromMatrixBlockTest: 950.212744 22/12/21 19:56:17 ERROR frame.FrameFromMatrixBlockTest: 964.515222 22/12/21 19:56:17 ERROR frame.FrameFromMatrixBlockTest: 966.944032 22/12/21 19:56:18 ERROR frame.FrameFromMatrixBlockTest: 965.85695 22/12/21 19:56:19 ERROR frame.FrameFromMatrixBlockTest: 956.783357 Before: 22/12/21 19:59:56 ERROR frame.FrameFromMatrixBlockTest: 2199.846241 22/12/21 19:59:58 ERROR frame.FrameFromMatrixBlockTest: 2373.381971 22/12/21 20:00:01 ERROR frame.FrameFromMatrixBlockTest: 2270.362306 22/12/21 20:00:03 ERROR frame.FrameFromMatrixBlockTest: 2324.07255 22/12/21 20:00:05 ERROR frame.FrameFromMatrixBlockTest: 2294.39046 22/12/21 20:00:08 ERROR frame.FrameFromMatrixBlockTest: 2284.978142 22/12/21 20:00:10 ERROR frame.FrameFromMatrixBlockTest: 2295.71655 22/12/21 20:00:12 ERROR frame.FrameFromMatrixBlockTest: 2297.712022 22/12/21 20:00:14 ERROR frame.FrameFromMatrixBlockTest: 2311.518135 22/12/21 20:00:17 ERROR frame.FrameFromMatrixBlockTest: 2467.055097 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
