phaniarnab commented on code in PR #1828:
URL: https://github.com/apache/systemds/pull/1828#discussion_r1205729611
##########
src/main/java/org/apache/sysds/runtime/transform/encode/MultiColumnEncoder.java:
##########
@@ -314,11 +314,12 @@ public MatrixBlock apply(CacheBlock<?> in) {
public MatrixBlock apply(CacheBlock<?> in, int k) {
// domain sizes are not updated if called from transformapply
boolean hasUDF = _columnEncoders.stream().anyMatch(e ->
e.hasEncoder(ColumnEncoderUDF.class));
+ boolean hasWE = _columnEncoders.stream().anyMatch(e ->
e.hasEncoder(ColumnEncoderWordEmbedding.class));
for(ColumnEncoderComposite columnEncoder : _columnEncoders)
columnEncoder.updateAllDCEncoders();
int numCols = getNumOutCols();
long estNNz = (long) in.getNumRows() * (hasUDF ? numCols :
(long) in.getNumColumns());
Review Comment:
This estimation of the number of non-zeros is incorrect for embedding
encoders. Dummycoding doesn't change the nnz but embedding does as embedding
produces dense outputs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
