Baunsgaard commented on PR #1838:
URL: https://github.com/apache/systemds/pull/1838#issuecomment-1581402342
Hi @cluelesprogrammer ,
Yes the files are located correctly.
Next steps are to (as we texted about before):
1. Take a bit of inspiration from the other files, to define an interface of
these methods such that you take an input X that you want to train on for the
hmm.dml and a input X that you want to predict on for the hmmPredict.dml. As a
starting point just make the methods call stop("NotImplemented").
2. You can integrate these into the system by adding them in
/src/main/java/org/apache/sysds/common/Builtins.java, again look at how other
builtin functions are done.
3. Then try to call it from a new file that is not in the repository,
perhaps make a /temp directory can a file called test.dml that calls your new
builtin.
4. Add a test that verifies that the builtin is working/throwing the not
implemented in src/test/java/org/apache/sysds/test/functions/builtin either
part1 or 2, again find some inspiration from other tests.
Once the above is done start making the HMM implementation.
I suggest you just do the work on top of this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
