phaniarnab commented on code in PR #1849:
URL: https://github.com/apache/systemds/pull/1849#discussion_r1242349693
##########
src/main/java/org/apache/sysds/common/Types.java:
##########
@@ -76,7 +76,7 @@ public boolean isUnknown() {
*/
public enum ValueType {
UINT4, UINT8, // Used for parsing in UINT values from numpy.
- FP32, FP64, INT32, INT64, BOOLEAN, STRING, UNKNOWN,
+ FP32, FP64, INT32, INT64, BOOLEAN, TRUE_BOOLEAN, STRING,
UNKNOWN,
Review Comment:
Is it possible to reuse the existing BOOLEAN value type instead of adding a
new one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
