slnkahveci commented on PR #1883:
URL: https://github.com/apache/systemds/pull/1883#issuecomment-1705377007
> > @Baunsgaard Could there be a column - row mismatch in the existing
img_crop script or test? It gives an error when the values in the test are not
equal. This also seems like the problem I'm working on. So I'm not sure if I
should look for the issue in my additions or the existing code.
>
> Can you be more specific, and also write up the example that does not
work, then I can also debug what is going on. But there is a likely possibility
that something does not work correctly when the number of rows and columns of
an image is bad, since there are not that many tests of the image primitives.
It doesn't work when the image is not square, for example for the values:
```
private final static int rows = 512;
private final static int cols = 256;
private final static int x_offset = 12;
private final static int y_offset = 24;
private final static float size = 0.6f;
```
I’m suspecting this mismatch because the expected B has flipped indexes:
```
%%MatrixMarket matrix coordinate real general
153 153 21112
1 1 241.32527313744777
2 1 138.9662793588828
4 1 233.29725808796292
5 1 153.8881182614073
...
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
