Baunsgaard commented on PR #1843: URL: https://github.com/apache/systemds/pull/1843#issuecomment-1714170216
> > We call this script in the beginning of building [ docker/entrypoint.sh](https://github.com/apache/systemds/blob/74be3fcdba8ec1015b860ce4f5a9a6758c306ac9/docker/entrypoint.sh) > > can it be that: > > ``` > > cd /github/workspace/src/main/cpp > > ./build.sh > > cd /github/workspace > > ``` > > > > > > > > > > > > > > > > > > > > > > > > does not build your binaries? > > how can I verify that? there were old binaries in the lib folder. When the git tests run, it should build new ones and replace the old one with it right ? > > even if this doesn't happen, the System.load() should load the old binaries that are present in cpp/lib and throw some error that says it could not find the native implementations. we always build the binaries on the GitHub testing. you can look up the raw logs : https://pipelinesghubeus22.actions.githubusercontent.com/99y4vYqbkvSsdnIzLIwwBWoa7RjP8bOodIdS7qcJ1UCIIzC9x5/_apis/pipelines/1/runs/40826/signedlogcontent/30?urlExpires=2023-09-11T15%3A56%3A29.5229959Z&urlSigningMethod=HMACV1&urlSignature=O1AR7JTkHl6vk70WkmpWS8AHt98TXruku%2B9w0t14eJI%3D and there it says something like: ``` 2023-09-11T13:45:53.2908375Z See also "/github/workspace/src/main/cpp/OPENBLAS/CMakeFiles/CMakeOutput.log". 2023-09-11T13:45:53.3071180Z make: *** No rule to make target 'install'. Stop. 2023-09-11T13:45:53.3123270Z ----------------------------------------------------------------------- 2023-09-11T13:45:53.3123866Z Check for unexpected dependencies added after code change or new setup: 2023-09-11T13:45:53.3124457Z Non-standard dependencies for libsystemds_mkl-linux-x86_64.so 2023-09-11T13:45:53.3192053Z Non-standard dependencies for libsystemds_openblas-linux-x86_64.so 2023-09-11T13:45:53.3264477Z ----------------------------------------------------------------------- 2023-09-11T13:45:53.4061848Z -- The CXX compiler identification is GNU 9.4.0 2023-09-11T13:45:53.4118015Z -- Check for working CXX compiler: /usr/bin/g++ 2023-09-11T13:45:53.5109326Z -- Check for working CXX compiler: /usr/bin/g++ -- works 2023-09-11T13:45:53.5126103Z -- Detecting CXX compiler ABI info 2023-09-11T13:45:53.6161549Z -- Detecting CXX compiler ABI info - done 2023-09-11T13:45:53.6300600Z -- Detecting CXX compile features 2023-09-11T13:45:53.6301203Z -- Detecting CXX compile features - done 2023-09-11T13:45:53.6334317Z -- Looking for C++ include pthread.h 2023-09-11T13:45:53.7454940Z -- Looking for C++ include pthread.h - found 2023-09-11T13:45:53.7455614Z -- Performing Test CMAKE_HAVE_LIBC_PTHREAD 2023-09-11T13:45:53.8619331Z -- Performing Test CMAKE_HAVE_LIBC_PTHREAD - Failed 2023-09-11T13:45:53.8621643Z -- Check if compiler accepts -pthread 2023-09-11T13:45:53.9742424Z -- Check if compiler accepts -pthread - yes 2023-09-11T13:45:53.9759399Z -- Found Threads: TRUE 2023-09-11T13:45:53.9771762Z -- Microsoft SEAL -> Version 3.7.0 detected 2023-09-11T13:45:53.9789595Z -- Microsoft SEAL -> Targets available: SEAL::seal_shared 2023-09-11T13:45:53.9790366Z -- Configuring done 2023-09-11T13:45:53.9811958Z -- Generating done 2023-09-11T13:45:53.9817535Z -- Build files have been written to: /github/workspace/src/main/cpp/HE 2023-09-11T13:45:54.0510546Z Scanning dependencies of target he 2023-09-11T13:45:54.0700122Z [ 33%] Building CXX object CMakeFiles/he.dir/libhe.cpp.o 2023-09-11T13:45:58.4275559Z [ 66%] Building CXX object CMakeFiles/he.dir/he.cpp.o 2023-09-11T13:46:02.6181043Z [100%] Linking CXX shared library libhe-Linux-x86_64.so 2023-09-11T13:46:02.7196534Z [100%] Built target he 2023-09-11T13:46:02.7462105Z Install the project... ``` and that indicate to me that the image lib is not compiled. we need to add it as an element to compile in: https://github.com/apache/systemds/blob/74be3fcdba8ec1015b860ce4f5a9a6758c306ac9/src/main/cpp/build.sh -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
