Baunsgaard commented on code in PR #1903:
URL: https://github.com/apache/systemds/pull/1903#discussion_r1322058990
##########
src/test/java/org/apache/sysds/test/functions/builtin/part1/BuiltinImageMirrorLinearizedTest.java:
##########
@@ -0,0 +1,81 @@
+
+package org.apache.sysds.test.functions.builtin.part1;
+
+import org.junit.Test;
+import org.apache.sysds.common.Types.ExecMode;
+import org.apache.sysds.common.Types.ExecType;
+import org.apache.sysds.runtime.matrix.data.MatrixValue;
+import org.apache.sysds.test.AutomatedTestBase;
+import org.apache.sysds.test.TestConfiguration;
+import org.apache.sysds.test.TestUtils;
+
+import java.util.HashMap;
+
+public class BuiltinImageMirrorLinearizedTest extends AutomatedTestBase {
+ private final static String TEST_NAME_LINEARIZED =
"image_mirror_linearized";
+ private final static String TEST_NAME = "image_mirror";
+ private final static String TEST_DIR = "functions/builtin/";
+ private final static String TEST_CLASS_DIR = TEST_DIR +
BuiltinImageMirrorLinearizedTest.class.getSimpleName() + "/";
+
+ private final static double eps = 1e-10;
+ private final static int rows = 64;
+ private final static int cols = 64;
Review Comment:
make sense, but we need to cover a "solid" set of cases automatically,
therefore we need to make the test run though multiple vairations.
I suggest writing the tests with the Parameterized interface, like in :
src/test/java/org/apache/sysds/test/functions/federated/primitives/FederatedFullAggregateTest.java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
