Baunsgaard commented on PR #1843: URL: https://github.com/apache/systemds/pull/1843#issuecomment-1722190295
> > My main comment is the comparison is not fair. There are some things we can do to improve it if you want (read the detailed comments for more). > > Hi @Baunsgaard , thank your for reviewing the code and the suggestions. Rest assured, I will address all of them after my presentation. > > could you be more specific, how can I make the comparison fairer? I will be incorporating your previous suggestions of calculating std and analysing dml execution time using -stats flag. Do you have any further suggestions? It would be interesting for the presentation to address this issue before that. The fairest comparison would be to integrate the native instruction as a DML supported command. It does not take long to make. But requires you to know where to do it. Once integrated we can compare with the overhead of the system on both executions and thereby get a fair comparison. For now the stats comparison is close enough. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
