Baunsgaard commented on PR #1956: URL: https://github.com/apache/systemds/pull/1956#issuecomment-1872512347
LGTM, I think the Queue make things slower instead of the boolean list, but if we need to support the dynamic lengths of the Lists or nested Lists, then this fix makes sense. And the live variables management is a low overhead to begin with so, all good from my side. We need to run the tests again once the main branch is clear of failing tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
