-1 Thanks for preparing the RC. I could reproduce the slf4j issue (thanks to Sebastian). We need another RC with the issue fixed.
Regards, Arnab.. On Wed, Feb 14, 2024 at 9:36 PM arnab phani <[email protected]> wrote: > Thanks for the comments. > Did you get the error while using the Jar to execute any dml file? > I think we always pack the systemds jar redundantly in the lib folder for > self-containment. We will verify from the previous release's artifacts. > Isn't the Python API update a part of the Python release, which we usually > do after the actual release in a separate process? > The SLF4J error, if a bug, is a blocker for this RC. Other comments > regarding the notice and README, I believe, are minor and can be fixed > before release. > > Regards, > Arnab.. > > On Wed, Feb 14, 2024 at 8:47 PM Sebastian Baunsgaard <[email protected]> > wrote: > >> Hi Janardhan, and dev team >> >> Thanks for preparing the release. I think there are a few things wrong in >> the release artifacts: >> >> 1. when running it always output: >> >> SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder". >> SLF4J: Defaulting to no-operation (NOP) logger implementation >> SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for >> further details. >> >> Even when I specify a configuration file, this indicate that the jar >> files included are doing something wrong. >> Am I the only one that see this behavior? If not then I think we need to >> fix it and do another release. >> >> 2. The systemds-3.2.0.jar is duplicated two places. 1. in the root, 2. >> inside the lib folder, I think the release should only have 1. >> >> 3. The notice says: >> Copyright [2015-2021] The Apache Software Foundation >> Instead of until this year. >> >> 4. The README indicate a spark 2 cluster and java 8, instead of the >> updated version. >> >> 5. The jar file contains more files than needed from the scripts folder, >> such as aws, pipelines, utils, algorithms and datagen. >> >> 6. The release artifact did not update the python API, therefore there is >> missing builtin functions that should be generated (tSNE). >> >> Best regards >> Sebastian >> >> On Tue, 2024-02-13 at 08:00 +0530, Janardhan wrote: >> > Greetings, >> > >> > Voting request for the release candidate as Apache SystemDS version >> 3.2.0 >> > >> > The vote is open for at least 72 hours and passes if a majority of at >> > least 3 +1 PMC votes are cast. >> > >> > [ ] +1 Release this package as Apache SystemDS 3.2.0 >> > [ ] -1 Do not release this package because ... >> > >> > To learn more about Apache SystemDS, please see >> > https://systemds.apache.org/ >> > >> > >> > Release artifacts >> > --- >> > >> > The tag to be voted on is 3.2.0-rc1 >> > (fdbd240af53dffd9b72e662cf854fb4cfee172bd): >> > https://github.com/apache/systemds/releases/tag/3.2.0-rc1 >> > >> > The release artifacts can be found at: >> > https://dist.apache.org/repos/dist/dev/systemds/3.2.0-rc1/ >> > >> > The maven release artifacts, including signatures, digests, etc. can >> > be found at: >> > >> https://repository.apache.org/content/repositories/orgapachesystemds-1093/org/apache/systemds/systemds/3.2.0/ >> > >> > >> > >> > Apache Release policy >> > --- >> > http://www.apache.org/legal/release-policy.html >> > >> > >> > How can I help test this release? >> > --- >> > If you are a SystemDS contributor/user, you can help us test this >> release >> > by taking an existing Algorithm or workload and running on this release >> > candidate, then reporting any regressions. >> > >> > Reach out to me if you need help with testing. >> > >> > >> > What justifies a -1 vote for this release? >> > --- >> > -1 votes should only occur for significant stop-ship bugs or legal >> related >> > issues (e.g. wrong license, missing header files, etc). Minor bugs or >> > regressions should not block this release. >> > >> > >> > Best Regards, >> > Janardhan >> > release key: https://s.apache.org/janardhan >> >>
