Baunsgaard commented on code in PR #2268:
URL: https://github.com/apache/systemds/pull/2268#discussion_r2131763285
##########
scripts/builtin/glove.dml:
##########
@@ -119,7 +141,7 @@ gloveWithCoocMatrix = function(matrix[double] cooc_matrix,
frame[Unknown] cooc_i
G = cbind(cooc_index[,2], as.frame(G));
}
-glove = function(
+f_glove = function(
Review Comment:
we use the f_ to indicate that this is the public function, therefore we
should not modify this line.
the rest of the functions in this file are private, and therefore not
available from outside.
##########
scripts/builtin/shapExplainer.dml:
##########
@@ -51,9 +51,8 @@
# S Matrix holding the shapley values along the cols, one row per
instance.
# expected Double holding the average prediction of all instances.
# -----------------------------------------------------------------------------
-s_shapExplainer = function(String model_function, list[unknown] model_args,
Matrix[Double] x_instances,
- Matrix[Double] X_bg, Integer n_permutations = 10, Integer n_samples = 100,
Integer remove_non_var=0,
- Matrix[Double] partitions=as.matrix(-1), Integer seed = -1, Integer
verbose = 0)
+
+s_shapExplainer = function(String model_func, list[unknown] model_args,
Matrix[Double] x_instances, Matrix[Double] X_bg, Integer n_permutations = 10,
Integer n_samples = 100, Integer remove_non_var=0, Matrix[Double]
partitions=as.matrix(-1), Integer seed = -1, Integer verbose = 0)
Review Comment:
avoid changing the names of the arguments, such as model_function ->
model_func.
This would break backwards compatibility.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
