j143 commented on code in PR #2319:
URL: https://github.com/apache/systemds/pull/2319#discussion_r2312233257
##########
src/main/java/org/apache/sysds/runtime/instructions/OOCInstructionParser.java:
##########
@@ -59,7 +60,8 @@ public static OOCInstruction
parseSingleInstruction(InstructionType ooctype, Str
return
BinaryOOCInstruction.parseInstruction(str);
case AggregateBinary:
case MAPMM:
- return
MatrixVectorBinaryOOCInstruction.parseInstruction(str);
+ return
MatrixMatrixBinaryOOCInstruction.parseInstruction(str);
+// return
MatrixVectorBinaryOOCInstruction.parseInstruction(str);
Review Comment:
need some help in wiring this.
1. shall I use MatrixMultiplyOOCInstruction class and correspondingly use
Matrix-Vector or Matrix-Matrix?
2. or keep all this in same class MatrixMultiply with private MatrixVector
and MatrixMatrix class?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
