mboehm7 commented on PR #2323: URL: https://github.com/apache/systemds/pull/2323#issuecomment-3316092509
LGTM - thanks for the patch @j143. Overall, this was a good start. During the merge I made the following additional modifications: - Changed the TSMM OOC instruction to consume the stream directly but produce a normal non-OOC output because it is a single block anyway - Added a validation check so we fail with unsupported operations if the dimensions do not qualify for OOC - Generalized the code so it works for both left and right TSMM - Eliminated unnecessary warnings (imports, unused variables) - Extended the test to cover both dense and sparse -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
