Baunsgaard commented on a change in pull request #892: Extend Python API (rand, lm, matrix multiplication) URL: https://github.com/apache/systemml/pull/892#discussion_r410371982
########## File path: src/main/python/tests/test_matrix_aggregations.py ########## @@ -25,6 +25,8 @@ import warnings import unittest import numpy as np +import scipy.stats as st Review comment: The reason why some tests fail is: ``` 2020-04-17T16:54:38.5699934Z Traceback (most recent call last): 2020-04-17T16:54:38.5701814Z File "tests/test_matrix_aggregations.py", line 28, in <module> 2020-04-17T16:54:38.5702098Z import scipy.stats as st 2020-04-17T16:54:38.5702821Z ModuleNotFoundError: No module named 'scipy' 2020-04-17T16:54:38.5888836Z ##[error]Process completed with exit code 1. ``` We can fix that by either adding SciPy as a dependency or not use it. It could be useful for other tests, so we could add it. Do you have any opinions on this? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
