Baunsgaard commented on a change in pull request #892: Extend Python API (rand, lm, matrix multiplication) URL: https://github.com/apache/systemml/pull/892#discussion_r410373065
########## File path: src/main/python/tests/test_matrix_aggregations.py ########## @@ -84,6 +86,63 @@ def test_var2(self): def test_var3(self): self.assertTrue(np.allclose(sds.matrix(m1).var(axis=1).compute(), m1.var(axis=1, ddof=1).reshape(dim, 1))) + def test_rand_basic(self): Review comment: I would make a new file, maybe call it test_matrix_rand.py, since rand does not fit into aggregation operations. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services