Continuing the JIRA discussion here: So I'm -1 on this change. I wouldn't be happy with Java code that downcast from an interface to an implementation class and then used reflection to modify its fields ... that's pretty much what we have here.
Yes the casting can be solved, but I didn't exactly follow where we have reflection sorry. Is it in ComponentElementImpl.addMixin ? On Sat, Aug 13, 2011 at 12:45 AM, Howard Lewis Ship <[email protected]>wrote: > See notes here: > > > https://issues.apache.org/jira/browse/TAP5-1606?focusedCommentId=13084434#comment-13084434 > > I'm -1 on this change. It goes against an important part of the > Tapestry design: that embedded components are part of a components > internal structure and not exposed to the outside world as a safeguard > that allows a component implementation to be changed without breaking > usages of the component. This @EmbeddedMixin tears apart that barrier. > > -- > Howard M. Lewis Ship > > Creator of Apache Tapestry > > The source for Tapestry training, mentoring and support. Contact me to > learn how I can get you up and productive in Tapestry fast! > > (971) 678-5210 > http://howardlewisship.com > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > >
