On Thu, Aug 25, 2011 at 8:40 AM, Taha Hafeez <tawus.tapes...@gmail.com> wrote: > I had a look at the code. It may not be the best of designs but it > certainly is a good resource to learn about the internals of tapestry. > Would love you see a blog post about its implementation !!
So far, nobody has stepped up to propose a better design to solve the same issue. It may not be the best design, but it's certainly not the worst either and it addresses the problem in a generic manner rather than for a specific case or component only. The simple suggestions that were given do not address the whole problem. Personally, I'd take a decent working solution any day over no solution. Kalle > On Mon, Aug 15, 2011 at 11:48 PM, dragan.sahpas...@gmail.com > <dragan.sahpas...@gmail.com> wrote: >> On Mon, Aug 15, 2011 at 8:13 PM, Howard Lewis Ship <hls...@gmail.com> wrote: >> >>> I've just backed out commit d8bf4fe19331faa3eaddc4a3f6a9d48827a7a590 >>> which added the EmbeddedMixin annotation & support. >>> >>> Sorry, Dragan! >>> >> >> Nothing to be sorry about. I got pretty useful comments. >> >> Cheers, >> Dragan Sahpaski >> >>> >>> On Mon, Aug 15, 2011 at 11:06 AM, dragan.sahpas...@gmail.com >>> <dragan.sahpas...@gmail.com> wrote: >>> > Hi, >>> > On Mon, Aug 15, 2011 at 2:11 PM, Thiago H. de Paula Figueiredo < >>> > thiag...@gmail.com> wrote: >>> > >>> >> On Sat, 13 Aug 2011 01:39:36 -0300, Robert Zeigler < >>> >> robert.zeig...@roxanemy.com> wrote: >>> >> >>> >> I disagree with your assessment of mixins. Mixins are primarily tied >>> to >>> >>> the component lifecycle, not to specific component implementations. >>> There >>> >>> are certainly some mixins that can't be universally applied (eg: they >>> may >>> >>> assume that the component is a ClientElement which may or may not be >>> true), >>> >>> but the way you go about implementing them doesn't ordinarily depend on >>> the >>> >>> internal structure of the component. Perhaps the closest >>> >>> framework-supported exception to that is the @BindParameter, but even >>> there >>> >>> you're working with published (ie /public/) information about >>> components, >>> >>> rather than private/internal information. >>> >>> >>> >> >>> >> I couldn't have said it better myself, Robert. :) >>> >> >>> >> -1 to EmbeddedMixin. If you want to modify the output of GridCells >>> inside a >>> >> Grid, you can still add the mixin to Grid itself. >>> > >>> > >>> > I don't. I just want to read the gridCell's propertyValue, propertyName >>> and >>> > the current row object. >>> > >>> > >>> >> Not much of a difference. By the way, couldn't we provide some better >>> way >>> >> to find elements when writing code that uses MarkupWriter and Element? >>> Does >>> >> tapestry-xpath provide that? It would definetely simplify a lot some DOM >>> >> rewriting code I've written. >>> >> >>> > >>> > True that. Haven't used it so I can't comment on it. >>> > >>> > Cheers, >>> > Dragan Sahpaski >>> > >>> >> >>> >> -- >>> >> Thiago H. de Paula Figueiredo >>> >> Independent Java, Apache Tapestry 5 and Hibernate consultant, developer, >>> >> and instructor >>> >> Owner, Ars Machina Tecnologia da Informação Ltda. >>> >> http://www.arsmachina.com.br >>> >> >>> >> >>> >> >>> ------------------------------**------------------------------**--------- >>> >> To unsubscribe, e-mail: dev-unsubscribe@tapestry.**apache.org< >>> dev-unsubscr...@tapestry.apache.org> >>> >> For additional commands, e-mail: dev-h...@tapestry.apache.org >>> >> >>> >> >>> > >>> >>> >>> >>> -- >>> Howard M. Lewis Ship >>> >>> Creator of Apache Tapestry >>> >>> The source for Tapestry training, mentoring and support. Contact me to >>> learn how I can get you up and productive in Tapestry fast! >>> >>> (971) 678-5210 >>> http://howardlewisship.com >>> >>> --------------------------------------------------------------------- >>> To unsubscribe, e-mail: dev-unsubscr...@tapestry.apache.org >>> For additional commands, e-mail: dev-h...@tapestry.apache.org >>> >>> >> > > > > -- > Regards > > Taha Hafeez Siddiqi (tawus) > http://tawus.wordpress.com > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@tapestry.apache.org > For additional commands, e-mail: dev-h...@tapestry.apache.org > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tapestry.apache.org For additional commands, e-mail: dev-h...@tapestry.apache.org