Jochen, what you're talking about is actually GitHub Pull Requests -- they do exactly this.
On Mon, Oct 28, 2013 at 11:34 AM, Jochen Berger <foober...@gmail.com> wrote: > Am 27.10.2013 15:03, schrieb Lenny Primak: > > Quick Jira search reveals bugs I care about: >> Basically, this is a result of a search of issues that >> are reported by me, voted on my me or watched by me: >> > > Maybe we can find a way to better mark "low-hanging fruit", i.e. use JIRA > labels to point out, which issues have patches attached and which ones > include tests and so on? > What about putting up a Wiki page with guidelines that patch writers > should stick to when they submit patches? > I think there are a lot of open issues with patches dangling around with > no committer taking care of them (not even by commenting on them or > requesting improvements). I find it quite annoying to find issues, > submitting patches and not getting them applied because (at least that's > what I suspect) they are to hard to find for people with commit access. > What do you think of the following (not necessarily in that order) > * Let's use the "patch" label for all issues that have a patch attached > * Find all issues that have an attachment but do not have the > "patch" label and assign it to them if the attachment is a patch > * Create the Wiki page with the patch guidelines and link it with JIRA > so that everybody who submits a patch will have to read it. Maybe > even post a comment with link to the page on all open issues with > patches > > I think there's already a lot of improvement up to here. If you're a > committer and can't sleep at night, just filter for open issues with the > patch label. > Now for the time-consuming tasks: > > * Go through the issues with the "patch" label, check if they contain > a test and apply the "contains-test" label > * Go through the issues with the "patch" label, check if the patch > applies cleanly to master and, if it doesn't, ask the committer to > rebase it and apply the "needs-rebase" label > > I guess, some of this can be done by a script, at least the second task. > > * Go through the issues that have the "patch" and "contains-test" > labels but not the "needs-rebase" label and apply the patches or > leave a comment what needs to be improved. > > I know, some of this will take a lot of time, but I think, it can help us > in getting some of the good patches that are already there applied and > encourage people to write patches. > And the best thing is, only the last part has to be taken care of by an > actual committer, all the tinkering with the labels can be done by any > regular JIRA user. > > Jochen > > > ------------------------------**------------------------------**--------- > To unsubscribe, e-mail: > dev-unsubscribe@tapestry.**apache.org<dev-unsubscr...@tapestry.apache.org> > For additional commands, e-mail: dev-h...@tapestry.apache.org > > -- Dmitry Gusev AnjLab Team http://anjlab.com
