Hello, Jochen! I'll try to take a look and fix them before the weekend. If not, feel free to revert it in the 5.4.x branch.
On Mon, Mar 20, 2017 at 9:52 AM, Jochen Kemnade <jochen.kemn...@eddyson.de> wrote: > Hi, > > Am 20.03.2017 um 09:53 schrieb Jochen Kemnade: > >> Am 19.03.2017 um 21:59 schrieb Thiago H. de Paula Figueiredo: >> >>> https://issues.apache.org/jira/browse/TAP5-2225 finished and committed >>> to >>> both 5.4.2 and 5.5 (master). Feedback welcome! >>> >> >> ./gradlew tapestry-beanvalidator:test --tests >> org.apache.tapestry5.beanvalidator.integration.TapestryBeanV >> alidationIntegrationTests.nested_object_validation >> > > tapestry-core:testWithPrototype also fails. > > I'd like to get 5.4.2 by this weekend. Thiago, can you please fix or > revert TAP5-2225 in the 5.4.x branch? > > Thanks, > Jochen > > > >> >> >> fails with a client-side error: dom.wrap(id).trigger is not a function >> >> >>> On Wed, Mar 8, 2017 at 11:45 AM, Thiago H. de Paula Figueiredo < >>> thiag...@gmail.com> wrote: >>> >>> I've started https://issues.apache.org/jira/browse/TAP5-2225 but I >>>> haven't finished yet. I was planning to work on this next week's >>>> weekend. >>>> Jochen, if you want to go ahead, I can make another release later. Also, >>>> thank you very, very much for taking TAP5-2575. :) >>>> >>>> On Wed, Mar 8, 2017 at 7:45 AM, Jochen Kemnade >>>> <jochen.kemn...@eddyson.de> >>>> wrote: >>>> >>>> Hi, >>>>> >>>>> due to TAP5-2575 we'll probably have to release 5.4.2 soon. I'll try to >>>>> address that issue. >>>>> Is there anything we want to pick from master? Or anything else we want >>>>> to include? >>>>> >>>>> Jochen >>>>> >>>>> --------------------------------------------------------------------- >>>>> To unsubscribe, e-mail: dev-unsubscr...@tapestry.apache.org >>>>> For additional commands, e-mail: dev-h...@tapestry.apache.org >>>>> >>>>> >>>>> >>>> >>>> -- >>>> Thiago >>>> >>>> >>> >>> >>> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@tapestry.apache.org >> For additional commands, e-mail: dev-h...@tapestry.apache.org >> >> > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@tapestry.apache.org > For additional commands, e-mail: dev-h...@tapestry.apache.org > > -- Thiago