Btw.: Are there any tests for the new feature or just the demo page?
----- On Mar 24, 2017, at 9:03 AM, Jochen Kemnade [email protected]
wrote:
> Thiago,
>
> I've had a look at the new code and here's what I've found so far:
>
> The @PublishEvent JavaDoc is misleading:
> It says that the event handler method is "to be called in JavaScript through
> the
> t5/core/triggerServerEvent function", but there is no such function.
>
> An ElementWrapper (e.g. dom.body or dom('#foo')) passed as `element` is not
> handled correctly by getEventUrl. You should probably add
> if element instanceof ElementWrapper
> element = element.element
>
> Shouldn't dom.getEventUrl throw or at least warn if it cannot determine the
> url
> for the event, e.g. if you forget to add the @PublishEvent annotation?
>
> Jochen
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
