Hi Thiago, I was thinking of merging it to 5.6.
It has no functional changes and tapestry runtime jars can still run on java 8. The jars are just built with the java 11 compiler, but byte code level is still java 8 for runtime. I'm saying "for runtime", because one tapestry-javadoc would now require JDK11, so if anyone has custom javadocs for their tapestry components they will be forced to upgrade their java (or temporarily use old tapestry-javadoc dependency for compatibility). Not sure about switching to java 11 byte code for 5.6. I'd love to do this, because it would allow running tests on java 11 bytecode which we currently miss. I still plan to write a test for https://issues.apache.org/jira/browse/TAP5-2611 With java 8 as main target I have to create a new module just for java 11 compatibility in tests, on the other hand if we switch target compatibility to java 11 in 5.6 already I could create that test in existing module. All tapestry apps I'm working on are on java 11 already, but I realise not everyone is migrated and it would be nice to get some feedback from community about it. On Mon, Sep 16, 2019 at 5:27 PM Thiago H. de Paula Figueiredo < thiag...@gmail.com> wrote: > On Mon, Aug 26, 2019 at 8:17 PM Dmitry Gusev <dmitry.gu...@gmail.com> > wrote: > > > Hi all, > > > > Hello! > > > > I managed to run a green build on my local machine on Java 11 as part of > > https://issues.apache.org/jira/browse/TAP5-2613, PR is here: > > https://github.com/apache/tapestry-5/pull/26 > > > Awesome! Thank you very much for that! I love that you fixed the taglet > support. > > > > I haven't tried Java 12 or above, not sure it's worth supporting any > > intermediate releases prior to Java 17 at this stage > > as that would be the next long term support (LTS) release as Java 11 > > currently is. All major fixes should be back ported to 11.x. > > > > Wouldn't the next LTS Java support be 2014? Looking at > https://www.oracle.com/technetwork/java/java-se-support-roadmap.html, it > seems that the Oracle's plan is to release one LTS version, then 2 non-LTS > ones, then another LTS. But, of course, I may be wrong, and often I am. :D > > Otherwise, I agree about only supporting LTS Java versions. > > Dmitry, I'm not sure whether you're suggesting merging this pull request > for 5.6 or 5.5. I still believe we should release 5.5 targeting Java 8 > bytecode, so we still support everyone who didn't upgrade to Java 11 yet, > and, as soon as possible, release 5.6 using Java 11 for both source and > target bytecode. > > The only thing I still want to do in 5.5 is the support for running > Tapestry without Bootstrap, something I'm planning to work in the next > days. The work in progress has been done on the 'bootstrapless' branch so > far. > > > > It would be nice to get a green build on Jenkins for it while we're > waiting > > for the stable 5.5.x. > > I'll try to look at it next week, but won't mind if anyone can do it :) > > > > The last build failure was due to failing to download one DTD file, > http://www.w3.org/TR/xhtml1/DTD/xhtml-lat1.ent, which is a little bit > weird. I'll try to rewrite that code a bit so it doesn't fail outright when > the download fails. > > > > Thiago, do you have a hint where I could read about Jenkins upgrade? > > Or maybe we could try Travis CI on GitHub. JIRA & GitHub have got a nice > > integration: JIRA ticket automatically referenced this PR. > > > > > > On Thu, Jun 27, 2019 at 9:47 PM Thiago H. de Paula Figueiredo < > > thiag...@gmail.com> wrote: > > > > > On Sat, Jun 22, 2019 at 6:56 PM Dmitry Gusev <dmitry.gu...@gmail.com> > > > wrote: > > > > > > > Hi everyone! > > > > > > > > > > Hello, everyone! > > > > > > > > > > I tried to upgrade the build to Java 11 before I found discussion in > > > > TAP5-2588, and I even upgraded most of it while experimenting and got > > all > > > > the tests green, except tapestry-javadoc module, which at first > glance > > > > requires code rewrite and not just library upgrades and minor fixes > as > > it > > > > was with core modules. > > > > > > > > > > Indeed, before we build Tapestry with Java 11, we'll need to rewrite at > > > least tapestry-javadoc, but I guess that's mostly it. If we want to > > provide > > > proper Java 9 modules too, we'll need to move some classes between > > > packages, since each package can only be in one module, and now we have > > > some packages with classes in more than one subproject/artifact/JAR. > Far > > > from trivial. > > > > > > > > > > So I would suggest to go straight to Java 11 after we release current > > > state > > > > of master (5.5.x). > > > > > > > > > > Agreed. > > > > > > What about Java 12? It was released last March. I haven't checked what > > are > > > the differences to 11, though. > > > > > > > > > > Starting from 5.6 all releases can remain binary compatible with java > > 8, > > > > but the build itself may leverage the java 11 compiler to start > testing > > > > java 8+ compatibility, as required by TAP5-2611, for example. > > > > > > > > > > Agreed too. > > > > > > And thanks Dmitry for starting this important discussion! > > > > > > -- > > > Thiago > > > > > > > > > -- > > Dmitry Gusev > > > > AnjLab Team > > http://anjlab.com > > > > > -- > Thiago > -- Dmitry Gusev AnjLab Team http://anjlab.com
