Ablu commented on code in PR #114:
URL:
https://github.com/apache/incubator-teaclave-trustzone-sdk/pull/114#discussion_r1435265884
##########
rust-toolchain.toml:
##########
@@ -18,6 +18,5 @@
# Toolchain override for rustup
[toolchain]
-channel = "nightly-2021-09-20"
-components = ["rust-src"]
+channel = "nightly"
Review Comment:
I would recommend to keep this pinned to "some" nightly to prevent things
from breaking in a non-bisectable manner.
##########
examples/authentication-rs/ta/build.rs:
##########
@@ -58,5 +82,12 @@ fn main() -> std::io::Result<()> {
println!("cargo:rustc-link-search={}", search_path.display());
println!("cargo:rustc-link-lib=static=utee");
+ println!("cargo:rustc-link-lib=static=utils");
+ println!("cargo:rustc-link-arg=-Tta.lds");
+ println!("cargo:rustc-link-arg=-e__ta_entry");
+ println!("cargo:rustc-link-arg=-pie");
+ println!("cargo:rustc-link-arg=-Os");
+ println!("cargo:rustc-link-arg=--sort-section=alignment");
+ println!("cargo:rustc-link-arg=--dynamic-list=dyn_list");
Review Comment:
One could probably move the boilerplate code into a crate that is only used
as dev-dependencies to avoid the duplication.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@teaclave.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@teaclave.apache.org
For additional commands, e-mail: dev-h...@teaclave.apache.org
