b49020 commented on code in PR #141: URL: https://github.com/apache/incubator-teaclave-trustzone-sdk/pull/141#discussion_r1671958080
########## .github/workflows/ci.yml: ########## @@ -65,41 +65,110 @@ jobs: # Setup Rust and toolchains ./setup.sh + # Build optee_os and optee_client for qemu_v8 + ./build_optee_libraries.sh $HOME + export OPTEE_DIR=$HOME + + # Build OP-TEE Rust examples for Arm 32-bit both host and TA + export ARCH_HOST=arm + export ARCH_TA=arm + source environment + make -j`nproc` + + # Build OP-TEE Rust examples for Arm 32-bit host and 64-bit TA + export ARCH_HOST=arm + unset ARCH_TA + source environment + make -j`nproc` + + # Build OP-TEE Rust examples for Arm 64-bit host and 32-bit TA + unset ARCH_HOST + export ARCH_TA=arm + source environment + make -j`nproc` Review Comment: Ditto. ########## .github/workflows/ci.yml: ########## @@ -65,41 +65,110 @@ jobs: # Setup Rust and toolchains ./setup.sh + # Build optee_os and optee_client for qemu_v8 + ./build_optee_libraries.sh $HOME + export OPTEE_DIR=$HOME + + # Build OP-TEE Rust examples for Arm 32-bit both host and TA + export ARCH_HOST=arm + export ARCH_TA=arm + source environment + make -j`nproc` + + # Build OP-TEE Rust examples for Arm 32-bit host and 64-bit TA + export ARCH_HOST=arm + unset ARCH_TA + source environment + make -j`nproc` + + # Build OP-TEE Rust examples for Arm 64-bit host and 32-bit TA + unset ARCH_HOST + export ARCH_TA=arm + source environment + make -j`nproc` + + # Build OP-TEE Rust examples for Arm 64-bit both host and TA + unset ARCH_TA + unset ARCH_HOST + source environment + make clean && make -j`nproc` + - name: Run tests for Arm 64-bit both host and TA + run: | + apt update && apt install libslirp-dev -y + source environment + (cd ci && ./ci.sh) + build-and-test-examples-for-64bit-std-TAs: + runs-on: ubuntu-latest + container: teaclave/teaclave-trustzone-sdk-build:0.3.0 + steps: + - name: Checkout repository + uses: actions/checkout@v2 + - name: Setting up $HOME + run: | + cp /root/.bashrc $HOME/.bashrc && + ln -sf /root/.rustup ~/.rustup && + ln -sf /root/.cargo ~/.cargo + - name: Building Arm 64-bit both host and TA (with STD enabled) + run: | + # Setup Rust and toolchains + ./setup.sh + + # Setup std dependencies + ./setup_std_dependencies.sh + # Build optee_os and optee_client for qemu_v8 ./build_optee_libraries.sh $HOME # Setup environment export OPTEE_DIR=$HOME + export STD=y source environment # Build OP-TEE Rust examples for Arm 64-bit both host and TA make -j`nproc` + - name: Run tests for Arm 64-bit both host and TA + run: | + apt update && apt install libslirp-dev -y + export STD=y + source environment + (cd ci && ./ci.sh) + build-and-test-examples-for-32bit-std-TAs: + runs-on: ubuntu-latest + container: teaclave/teaclave-trustzone-sdk-build:0.3.0 + steps: + - name: Checkout repository + uses: actions/checkout@v2 + - name: Setting up $HOME + run: | + cp /root/.bashrc $HOME/.bashrc && + ln -sf /root/.rustup ~/.rustup && + ln -sf /root/.cargo ~/.cargo + - name: Building Arm 64-bit both host and TA (with STD enabled) + run: | + # Setup Rust and toolchains + ./setup.sh - # Build OP-TEE Rust examples for Arm 64-bit host and 32-bit TA - export TA_DEV_KIT_DIR=~/optee_os/out/arm-plat-vexpress/export-ta_arm32/ - export CROSS_COMPILE_HOST=$CROSS_COMPILE64 - export CROSS_COMPILE_TA=$CROSS_COMPILE32 - export TARGET_HOST="aarch64-unknown-linux-gnu" - export TARGET_TA="arm-unknown-linux-gnueabihf" - make clean && make -j`nproc` + # Setup std dependencies + ./setup_std_dependencies.sh - # Build OP-TEE Rust examples for Arm 32-bit both host and TA - export TA_DEV_KIT_DIR=~/optee_os/out/arm-plat-vexpress/export-ta_arm32/ - export CROSS_COMPILE_HOST=$CROSS_COMPILE32 - export CROSS_COMPILE_TA=$CROSS_COMPILE32 - export TARGET_HOST="arm-unknown-linux-gnueabihf" - export TARGET_TA="arm-unknown-linux-gnueabihf" - (cd ~/optee_client && make clean && make CROSS_COMPILE=$CROSS_COMPILE32 WITH_TEEACL=0) - make clean && make -j`nproc` + # Build optee_os and optee_client for qemu_v8 + ./build_optee_libraries.sh $HOME - # Build OP-TEE Rust examples for Arm 32-bit host and 64-bit TA - export TA_DEV_KIT_DIR=~/optee_os/out/arm-plat-vexpress/export-ta_arm64/ - export CROSS_COMPILE_HOST=$CROSS_COMPILE32 - export CROSS_COMPILE_TA=$CROSS_COMPILE64 - export TARGET_HOST="arm-unknown-linux-gnueabihf" - export TARGET_TA="aarch64-unknown-linux-gnu" - make clean && make -j`nproc` + # Setup environment + export OPTEE_DIR=$HOME + export ARCH_TA=arm + export STD=y + source environment + # Build OP-TEE Rust examples for Arm 64-bit both host and TA + make -j`nproc` + - name: Run tests for Arm 64-bit both host and TA Review Comment: I suppose you meant here 32-bit TAs instead. ########## .github/workflows/ci.yml: ########## @@ -65,41 +65,110 @@ jobs: # Setup Rust and toolchains ./setup.sh + # Build optee_os and optee_client for qemu_v8 + ./build_optee_libraries.sh $HOME + export OPTEE_DIR=$HOME + + # Build OP-TEE Rust examples for Arm 32-bit both host and TA + export ARCH_HOST=arm + export ARCH_TA=arm + source environment + make -j`nproc` + + # Build OP-TEE Rust examples for Arm 32-bit host and 64-bit TA + export ARCH_HOST=arm + unset ARCH_TA + source environment + make -j`nproc` Review Comment: I think this deserves a clean like: ``` make clean && make -j`nproc` ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@teaclave.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@teaclave.apache.org For additional commands, e-mail: dev-h...@teaclave.apache.org