DemesneGH commented on code in PR #141: URL: https://github.com/apache/incubator-teaclave-trustzone-sdk/pull/141#discussion_r1670126269
########## examples/acipher-rs/ta/Makefile: ########## @@ -17,19 +17,23 @@ UUID ?= $(shell cat "../uuid.txt") -TARGET ?= aarch64-unknown-linux-gnu -CROSS_COMPILE ?= aarch64-linux-gnu- -OBJCOPY := $(CROSS_COMPILE)objcopy -LINKER_CFG := target.$(TARGET).linker=\"$(CROSS_COMPILE)ld.bfd\" +TARGET_TA ?= aarch64-unknown-linux-gnu +CROSS_COMPILE_TA ?= aarch64-linux-gnu- +OBJCOPY := $(CROSS_COMPILE_TA)objcopy +LINKER_CFG := target.$(TARGET_TA).linker=\"$(CROSS_COMPILE_TA)ld.bfd\" TA_SIGN_KEY ?= $(TA_DEV_KIT_DIR)/keys/default_ta.pem SIGN := $(TA_DEV_KIT_DIR)/scripts/sign_encrypt.py -OUT_DIR := $(CURDIR)/target/$(TARGET)/release +OUT_DIR := $(CURDIR)/target/$(TARGET_TA)/release all: ta strip sign ta: - @cargo build --target $(TARGET) --release --config $(LINKER_CFG) + @if [ $(STD) ]; then\ + xargo build --target $(TARGET_TA) --release --config $(LINKER_CFG) --verbose;\ Review Comment: The verbose is not necessary so it can be simplified as `BUILDER = $(if $(STD),xargo,cargo)`, will update later -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
