ivila opened a new pull request, #170:
URL: https://github.com/apache/incubator-teaclave-trustzone-sdk/pull/170
This PR aims to simplify the proto crate by making the following changes:
1. **Truncate `uuid.txt` Before Compilation**
The `build.rs` script in the proto crate currently serves only one
purpose: reading the UUID from uuid.txt and removing the extra newline at the
end. Instead of handling this at build time, we can clean up the file
beforehand using a simple shell command:
```shell
truncate -s 36 uuid.txt
```
This allows us to remove `build.rs` entirely and eliminate the `OUTDIR`
environment variable from `lib.rs`, making the crate cleaner and simpler.
2. **Use `num_enum` for Enum Conversion**
The manual implementation for converting between `Command` and `u32` can
be simplified using `num_enum`, reducing boilerplate and improving
maintainability.
For the detail changes, you can refer to the first commit of this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@teaclave.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@teaclave.apache.org
For additional commands, e-mail: dev-h...@teaclave.apache.org
