ivila commented on PR #170: URL: https://github.com/apache/incubator-teaclave-trustzone-sdk/pull/170#issuecomment-2684432656
> For the `uuid.txt`: I checked the code history, the `build.rs` was designed to generate the UUID if it doesn't exist and the generation functionality has been removed in [7de996c](https://github.com/apache/incubator-teaclave-trustzone-sdk/commit/7de996cdbc9f454fd41b18150f8a90bd033b2703). For the current `build.rs`, I agree to remove it. What would happen if we don't remove the extra newline of `uuid.txt`? Could our building script tolerate this case? If so, developers would not have to `truncate` manually. > > For the `num_enum`: It's a nice cleanup and looks good for me. If we don't remove the extra newline of `uuid.txt`, the `parse_str` of `Uuid` will report an error because we pass a string with 37 bytes. ``` rust // called `Result::unwrap()` on an `Err` value: InvalidLength { expected: Any([36, 32]), found: 37 } let uuid = Uuid::parse_str(proto::UUID).unwrap(); ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@teaclave.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@teaclave.apache.org For additional commands, e-mail: dev-h...@teaclave.apache.org
