[
https://issues.apache.org/jira/browse/TEPHRA-212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15840852#comment-15840852
]
ASF GitHub Bot commented on TEPHRA-212:
---------------------------------------
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/29#discussion_r98127853
--- Diff:
tephra-hbase-compat-1.1-base/src/main/java/org/apache/tephra/hbase/txprune/PruneUpperBoundWriter.java
---
@@ -0,0 +1,104 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.tephra.hbase.txprune;
+
+import org.slf4j.Logger;
--- End diff --
Since this code will run in HBase co-processor, use apache commons logging.
> CompactionState #savePruneUpperBoundForRegion put call might because problems
> if regions are not available
> ----------------------------------------------------------------------------------------------------------
>
> Key: TEPHRA-212
> URL: https://issues.apache.org/jira/browse/TEPHRA-212
> Project: Tephra
> Issue Type: Bug
> Affects Versions: 0.11.0-incubating
> Reporter: Gokul Gunasekaran
> Assignee: Gokul Gunasekaran
> Fix For: 0.11.0-incubating
>
>
> If the regions corresponding to prune state table are not available, trying
> to do a put to that table might cause multiple retries etc and might cause
> issues. Instead of doing this write in a synchronous fashion, this should be
> done asynchronously.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
