[ 
https://issues.apache.org/jira/browse/TEPHRA-212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15847644#comment-15847644
 ] 

ASF GitHub Bot commented on TEPHRA-212:
---------------------------------------

Github user poornachandra commented on a diff in the pull request:

    https://github.com/apache/incubator-tephra/pull/29#discussion_r98780134
  
    --- Diff: 
tephra-hbase-compat-1.1-base/src/main/java/org/apache/tephra/hbase/txprune/PruneUpperBoundWriter.java
 ---
    @@ -77,7 +78,7 @@ public void run() {
                   try {
                     dataJanitorState.savePruneUpperBoundForRegion(regionName, 
pruneUpperBound.get());
                   } catch (IOException ex) {
    -                LOG.warn("Cannot record prune upper bound in table after 
compacting region", ex);
    +                LOG.warn("Cannot record prune upper bound in table after 
compacting region " + ex.getMessage());
    --- End diff --
    
    We can still pass in the Throwable to the logger.


> CompactionState #savePruneUpperBoundForRegion put call might because problems 
> if regions are not available
> ----------------------------------------------------------------------------------------------------------
>
>                 Key: TEPHRA-212
>                 URL: https://issues.apache.org/jira/browse/TEPHRA-212
>             Project: Tephra
>          Issue Type: Bug
>    Affects Versions: 0.11.0-incubating
>            Reporter: Gokul Gunasekaran
>            Assignee: Gokul Gunasekaran
>             Fix For: 0.11.0-incubating
>
>
> If the regions corresponding to prune state table are not available, trying 
> to do a put to that table might cause multiple retries etc and might cause 
> issues. Instead of doing this write in a synchronous fashion, this should be 
> done asynchronously.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to