[ 
https://issues.apache.org/jira/browse/TEPHRA-214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15855512#comment-15855512
 ] 

ASF GitHub Bot commented on TEPHRA-214:
---------------------------------------

Github user poornachandra commented on a diff in the pull request:

    https://github.com/apache/incubator-tephra/pull/31#discussion_r99760211
  
    --- Diff: 
tephra-hbase-compat-1.1-base/src/main/java/org/apache/tephra/hbase/txprune/DataJanitorState.java
 ---
    @@ -120,6 +143,22 @@ public long getPruneUpperBoundForRegion(byte[] 
regionId) throws IOException {
        */
       public Map<byte[], Long> getPruneUpperBoundForRegions(SortedSet<byte[]> 
regions) throws IOException {
         Map<byte[], Long> resultMap = new TreeMap<>(Bytes.BYTES_COMPARATOR);
    +    List<RegionPruneInfo> regionPruneInfos = 
getPruneInfoForRegions(regions);
    +    for (RegionPruneInfo regionPruneInfo : regionPruneInfos) {
    +      resultMap.put(regionPruneInfo.getRegionName(), 
regionPruneInfo.getCompactionTimestamp());
    --- End diff --
    
    Same here, should be `regionPruneInfo.getPruneUpperBound()` instead of 
`regionPruneInfo.getCompactionTimestamp()`


> Provide a way to debug Transaction Pruning progress
> ---------------------------------------------------
>
>                 Key: TEPHRA-214
>                 URL: https://issues.apache.org/jira/browse/TEPHRA-214
>             Project: Tephra
>          Issue Type: Improvement
>            Reporter: Gokul Gunasekaran
>            Assignee: Gokul Gunasekaran
>
> It would be good to get information about what regions are lagging that might 
> be useful to debug why transaction pruning might not be happening. We do 
> print debug information but this method could be invoked on a need-basis 
> outside of the regular pruning operation.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to