[ 
https://issues.apache.org/jira/browse/TEPHRA-214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15855506#comment-15855506
 ] 

ASF GitHub Bot commented on TEPHRA-214:
---------------------------------------

Github user poornachandra commented on a diff in the pull request:

    https://github.com/apache/incubator-tephra/pull/31#discussion_r99759970
  
    --- Diff: 
tephra-hbase-compat-1.1-base/src/main/java/org/apache/tephra/hbase/txprune/DataJanitorState.java
 ---
    @@ -102,11 +107,29 @@ public void savePruneUpperBoundForRegion(byte[] 
regionId, long pruneUpperBound)
        * @throws IOException when not able to read the data from HBase
        */
       public long getPruneUpperBoundForRegion(byte[] regionId) throws 
IOException {
    +    RegionPruneInfo regionPruneInfo = getPruneInfoForRegion(regionId);
    +    return (regionPruneInfo == null) ? -1 : 
regionPruneInfo.getCompactionTimestamp();
    +  }
    +
    +  /**
    +   * Get the latest {@link RegionPruneInfo} for a given region.
    +   *
    +   * @param regionId region id
    +   * @return {@link RegionPruneInfo} for the region
    +   * @throws IOException when not able to read the data from HBase
    +   */
    +  public RegionPruneInfo getPruneInfoForRegion(byte[] regionId) throws 
IOException {
    --- End diff --
    
    This method needs to be annotated as `@Nullable`


> Provide a way to debug Transaction Pruning progress
> ---------------------------------------------------
>
>                 Key: TEPHRA-214
>                 URL: https://issues.apache.org/jira/browse/TEPHRA-214
>             Project: Tephra
>          Issue Type: Improvement
>            Reporter: Gokul Gunasekaran
>            Assignee: Gokul Gunasekaran
>
> It would be good to get information about what regions are lagging that might 
> be useful to debug why transaction pruning might not be happening. We do 
> print debug information but this method could be invoked on a need-basis 
> outside of the regular pruning operation.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to