seongjinyoon opened a new pull request, #3666:
URL: https://github.com/apache/texera/pull/3666
### Summary:
This PR implements support for downloadable private datasets, fixing issue
where private datasets could not be properly downloaded.
### Issue:
Previously, the system had restrictive logic that prevented private datasets
from being downloadable
- Dataset Creation: Users could not create private datasets that were
downloadable
- Dataset Editing: Users could not modify existing private datasets to be
downloadable
Closes #3665
### Changes Made:
**Frontend Changes:**
- When a dataset becomes private, downloads are no longer automatically
disabled.
- The downloadable toggle is no longer disabled for private datasets.
- Updated `isDownloadAllowed()` method to support both public and private
downloadable datasets
- Owners can always download
- For public datasets: Anyone can download if downloadable
- For private datasets: Users with access can download if downloadable
- No longer prevents setting private datasets as downloadable
**Backend Changes**
- No longer validates that "downloadable can only be true if dataset is
public"
- Changing dataset from public to private no longer automatically disables
downloads
- No longer prevents setting private datasets as downloadable
### Video:
The video demonstrates how the following datasets behave:
- private dataset download enabled
- private dataset download disabled
- public dataset download enabled
- public dataset download disabled
https://github.com/user-attachments/assets/b9811a4a-f59f-4d8e-847f-0e2f8374d322
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
